Improve file patterns for some backends. #147633
Conversation
Created using spr 1.3.6-beta.1
|
@llvm/pr-subscribers-github-workflow Author: Peter Collingbourne (pcc) ChangesI noticed that one of my PRs, #147624, did not get automatically Full diff: https://github.com/llvm/llvm-project/pull/147633.diff 1 Files Affected:
diff --git a/.github/new-prs-labeler.yml b/.github/new-prs-labeler.yml
index 863090af9af7e..b05e9c6c56ed0 100644
--- a/.github/new-prs-labeler.yml
+++ b/.github/new-prs-labeler.yml
@@ -784,18 +784,20 @@ backend:NVPTX:
backend:MIPS:
- '**/*mips*'
- '**/*Mips*'
+ - '**/*mips*/**'
+ - '**/*Mips*/**'
backend:RISC-V:
- - clang/**/*riscv*
- - clang/**/*RISCV*
- - llvm/**/*riscv*
- - llvm/**/*RISCV*
+ - '**/*riscv*'
+ - '**/*RISCV*'
+ - '**/*riscv*/**'
+ - '**/*RISCV*/**'
backend:Xtensa:
- - clang/**/*xtensa*
- - clang/**/*Xtensa*
- - llvm/**/*xtensa*
- - llvm/**/*Xtensa*
+ - '**/*xtensa*'
+ - '**/*Xtensa*'
+ - '**/*xtensa*/**'
+ - '**/*Xtensa*/**'
lld:coff:
- lld/**/COFF/**
|
| - '**/*mips*/**' | ||
| - '**/*Mips*/**' |
There was a problem hiding this comment.
Does ** only work after a /?
There was a problem hiding this comment.
Not sure, I was just cargo culting AMDGPU. https://github.com/actions/labeler doesn't say that anything besides ** works.
There was a problem hiding this comment.
I believe the underlying implementation is https://github.com/isaacs/minimatch#minimatch, so whatever works there.
There was a problem hiding this comment.
There don't seem to be any tests in that repository that test whether ** not on its own also matches /, so I assume it doesn't work.
I noticed that one of my PRs, #147624, did not get automatically
labelled with
backend:RISC-Vwhen it touched a test underllvm/test/CodeGen/RISCV. This seems to be because the pattern onlylooks for files named
*RISCV*or `riscv and not necessarily filesin a directory named like that. To fix that, let's make RISC-V use
a more accepting pattern, similar to AMDGPU, and do the same for two
other backends.